Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test fot the issue with cassette not recorded #206

Merged
merged 2 commits into from
Jun 18, 2021
Merged

add test fot the issue with cassette not recorded #206

merged 2 commits into from
Jun 18, 2021

Conversation

jscotka
Copy link
Collaborator

@jscotka jscotka commented Jun 17, 2021

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

lachmanfrantisek
lachmanfrantisek reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the some strange changes commit?

tests/test_E2E_example.py
Comment on lines +53 to +55
if cassette.mode == StorageMode.read:
setattr(socket, "socket", lambda x: x)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain this a bit (in the code/comment)?

@jscotka @lachmanfrantisek
Update tests/test_E2E_example.py
0febce3 
Co-authored-by: lachmanfrantisek <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@lachmanfrantisek lachmanfrantisek added the mergeit When set, zuul wil gate and merge the PR. label Jun 18, 2021
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 04bad53 into packit:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachmanfrantisek lachmanfrantisek lachmanfrantisek approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jscotka @lachmanfrantisek